| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |
| Date: | 2025-03-29 10:20:24 |
| Message-ID: | CAEZATCUdWL6Mv96SZ4atKudkz67Uv+LbO0BXoZVmLu-d=kpUaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, 29 Mar 2025 at 05:54, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>
> On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:
>
> > In ExecInitPartitionInfo(), it has comments like:
> >
> > * This duplicates much of the logic in ExecInitMerge(), so something
> > * changes there, look here too.
> >
> I would've expecetd the comment to be in ExecInitMerge(), asking the
> reader to look at other places the logic is duplicated.
>
There already is such a comment a little further up in
ExecInitMerge(), so I didn't bother repeating it.
I've committed the fix, except that I put the test case in merge.sql,
since part_abc_view doesn't exist in back branches of
partition_prune.sql, and it feels more like a MERGE bug anyway.
Thanks, all.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2025-03-29 10:40:19 | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |
| Previous Message | Gurjeet Singh | 2025-03-29 05:54:50 | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |