| From: | "Gurjeet Singh" <gurjeet(at)singh(dot)im> |
|---|---|
| To: | "Tender Wang" <tndrwang(at)gmail(dot)com>, "Dean Rasheed" <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | <exclusion(at)gmail(dot)com>, <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |
| Date: | 2025-03-29 05:54:50 |
| Message-ID: | D8SIN5I77I7S.4YF5B429CIGO@singh.im |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:
> In ExecInitPartitionInfo(), it has comments like:
>
> * This duplicates much of the logic in ExecInitMerge(), so something
> * changes there, look here too.
>
> ExecInitMerge() considers CMD_NOTHING operation.
> I give the attached fix.
I would've expecetd the comment to be in ExecInitMerge(), asking the
reader to look at other places the logic is duplicated.
Attached is a patch with an attempt at that; it includes the diff from
your patch, too, so I named it v2.
Best regards,
Gurjeet
http://Gurje.et
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Fix-cross-partition-merge-fail.patch | text/plain | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-03-29 10:20:24 | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |
| Previous Message | Tender Wang | 2025-03-29 02:39:12 | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |