From: | Tender Wang <tndrwang(at)gmail(dot)com> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |
Date: | 2025-03-29 10:40:19 |
Message-ID: | CAHewXNk7L3XxL5fVfKoWYXMHVPYQFN7i42Ui8LB8XwoNOeuEvg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> 于2025年3月29日周六 18:20写道:
> On Sat, 29 Mar 2025 at 05:54, Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> >
> > On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:
> >
> > > In ExecInitPartitionInfo(), it has comments like:
> > >
> > > * This duplicates much of the logic in ExecInitMerge(), so something
> > > * changes there, look here too.
> > >
> > I would've expecetd the comment to be in ExecInitMerge(), asking the
> > reader to look at other places the logic is duplicated.
> >
>
> There already is such a comment a little further up in
> ExecInitMerge(), so I didn't bother repeating it.
>
> I've committed the fix, except that I put the test case in merge.sql,
> since part_abc_view doesn't exist in back branches of
> partition_prune.sql, and it feels more like a MERGE bug anyway.
>
Agree.
Thanks for pushing.
--
Thanks,
Tender Wang
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2025-03-29 16:21:09 | Fwd: PostgreSQL JDBC 42.7.5 returns an unexpected catalog name |
Previous Message | Dean Rasheed | 2025-03-29 10:20:24 | Re: BUG #18871: Cross-partition MERGE fails with unclear internal error |