| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | Steven Niu <niushiji(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [Patch] remove duplicated smgrclose |
| Date: | 2024-08-01 12:32:11 |
| Message-ID: | CAEG8a3L9qHCw3nWT1iwuHdHMcghqLWxDyu+F0ioDZrZJ1d8Ffw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Steven,
On Wed, Jul 31, 2024 at 11:16 AM Steven Niu <niushiji(at)gmail(dot)com> wrote:
>
> Hello, hackers,
>
> I think there may be some duplicated codes.
> Function smgrDoPendingDeletes() calls both smgrdounlinkall() and smgrclose().
> But both functions would close SMgrRelation object, it's dupliacted behavior?
>
> So I make this patch. Could someone take a look at it?
>
> Thanks for your help,
> Steven
>
> From Highgo.com
>
>
You change LGTM, but the patch seems not to be applied to HEAD,
I generate the attached v2 using `git format` with some commit message.
--
Regards
Junwang Zhao
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-remove-duplicated-smgrclose.patch | application/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Robert Haas | 2024-08-01 11:57:05 | Re: can we mark upper/lower/textlike functions leakproof? |