From: | Steven Niu <niushiji(at)gmail(dot)com> |
---|---|
To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [Patch] remove duplicated smgrclose |
Date: | 2024-08-02 04:12:39 |
Message-ID: | CABBtG=funw1K7s5AJ4SQrWCZ9kGqYLoKh2gAZq94rAUizS4HQA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, Junwang,
Thank you for the review and excellent summary in commit message!
This is my first contribution to community, and not so familiar with the
overall process.
After reading the process again, it looks like that I'm not qualified to
submit the patch to commitfest as I never had reviewed others' work. :(
If so, could you please help to submit it to commitfest?
Best Regards,
Steven
Junwang Zhao <zhjwpku(at)gmail(dot)com> 于2024年8月1日周四 20:32写道:
> Hi Steven,
>
> On Wed, Jul 31, 2024 at 11:16 AM Steven Niu <niushiji(at)gmail(dot)com> wrote:
> >
> > Hello, hackers,
> >
> > I think there may be some duplicated codes.
> > Function smgrDoPendingDeletes() calls both smgrdounlinkall() and
> smgrclose().
> > But both functions would close SMgrRelation object, it's dupliacted
> behavior?
> >
> > So I make this patch. Could someone take a look at it?
> >
> > Thanks for your help,
> > Steven
> >
> > From Highgo.com
> >
> >
> You change LGTM, but the patch seems not to be applied to HEAD,
> I generate the attached v2 using `git format` with some commit message.
>
> --
> Regards
> Junwang Zhao
>
From | Date | Subject | |
---|---|---|---|
Next Message | Shubham Khanna | 2024-08-02 04:26:59 | Re: Pgoutput not capturing the generated columns |
Previous Message | Tom Lane | 2024-08-02 04:00:57 | Re: Query results vary depending on the plan cache mode used |