Re: [PATCH v1] eliminate duplicate code in table.c

From: Junwang Zhao <zhjwpku(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 15:58:06
Message-ID: CAEG8a3+JQz0Tz39P6W6Jw+kxYExRdc4zhnADFN7bq23j094WRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

LGTM

On Thu, Jul 21, 2022 at 11:52 PM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> Hi Junwang,
>
> > btw, there are some typos in Patch v5, %s/ralation/relation/g
>
> D'oh!
>
> > yeah, IMHO validate_relation_kind() is better ;)
>
> Cool. Here is the corrected patch. Thanks!
>
> --
> Best regards,
> Aleksander Alekseev

--
Regards
Junwang Zhao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2022-07-21 16:10:05 Re: Make name optional in CREATE STATISTICS
Previous Message Aleksander Alekseev 2022-07-21 15:51:57 Re: [PATCH v1] eliminate duplicate code in table.c