Re: [PATCH v1] eliminate duplicate code in table.c

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: zhjwpku(at)gmail(dot)com
Cc: aleksander(at)timescale(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, amit(dot)kapila16(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-22 02:09:22
Message-ID: 20220722.110922.895731314002748653.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

+ errmsg("cannot operate on relation \"%s\"",

Other callers of errdetail_relkind_not_supported() describing
operations concretely. In that sense we I think should say "cannot
open relation \"%s\"" here.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2022-07-22 02:17:00 question about `static inline` functions in header files
Previous Message Thomas Munro 2022-07-22 01:59:09 slot_creation_error failures