Re: [PATCH v1] eliminate duplicate code in table.c

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 15:51:57
Message-ID: CAJ7c6TM+Ng04u5ERm6ZYo0dP_ZnGtjLyyrpZn_rodSh4o9GLeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Junwang,

> btw, there are some typos in Patch v5, %s/ralation/relation/g

D'oh!

> yeah, IMHO validate_relation_kind() is better ;)

Cool. Here is the corrected patch. Thanks!

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v6-0001-Eliminate-duplicate-code-in-table.c.patch application/octet-stream 4.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2022-07-21 15:58:06 Re: [PATCH v1] eliminate duplicate code in table.c
Previous Message Martin Kalcher 2022-07-21 15:43:02 Re: [PATCH] Introduce array_shuffle() and array_sample()