Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

Hello,

Le mar. 12 nov. 2024 à 22:21, Robert Haas <robertmhaas(at)gmail(dot)com> a écrit :

> On Tue, Nov 12, 2024 at 4:02 PM Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > Sure looks easy enough to do (though it still lacks doc and tests
> changes). See patch attached.
>
> Yep, that's very small. I'm a bit wondering if it's too small, though.
> standard_ExplainOneQuery() seems to do some stuff with es->buffers
> even before it does planning, so if the idea is that this will be a
> noop without ANALYZE, maybe this doesn't implement that. Also, you
> should probably update the default value for auto_explain.log_buffers.
> In general, I would recommend "git grep 'es->buffers'" and look
> carefully at each place where it's mentioned and decide if anything
> needs to be changed. And then change the stuff that needs it, and
> include in your email an explanation of why the other things don't
> need to be changed, unless it's obvious.
>
>
It took me a while to get back to it. This new patch takes care of the
auto_explain extension, tests, and docs. I did quite a lot of tests, and it
now looks complete to me (though I may have missed something :) ).

Regards.

--
Guillaume.