| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Michael Christofides <michael(at)pgmustard(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE |
| Date: | 2024-11-12 21:21:35 |
| Message-ID: | CA+TgmoZO2HtDGHf7K4rmNdfUGuS=ngsPgwrH=JdyF6Okcnzfkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 12, 2024 at 4:02 PM Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Sure looks easy enough to do (though it still lacks doc and tests changes). See patch attached.
Yep, that's very small. I'm a bit wondering if it's too small, though.
standard_ExplainOneQuery() seems to do some stuff with es->buffers
even before it does planning, so if the idea is that this will be a
noop without ANALYZE, maybe this doesn't implement that. Also, you
should probably update the default value for auto_explain.log_buffers.
In general, I would recommend "git grep 'es->buffers'" and look
carefully at each place where it's mentioned and decide if anything
needs to be changed. And then change the stuff that needs it, and
include in your email an explanation of why the other things don't
need to be changed, unless it's obvious.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-11-12 21:23:10 | Re: Fix to increment the index scan counter for the bloom filter index |
| Previous Message | Heikki Linnakangas | 2024-11-12 21:17:42 | Re: Statistics Import and Export |