| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Christofides <michael(at)pgmustard(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE |
| Date: | 2024-11-20 00:12:37 |
| Message-ID: | CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I'm with Robert on this one. I'm a grudging +1 to buffers defaulting on,
and a strong -1 to all the other proposals. Guillaume, the patch looks
pretty good. I would like to see some of the example output have more than
just "shared hit" and "read" though: let's throw some "dirtied" and
"written" in there as well.
It defaults to <literal>TRUE</literal> when <literal>ANALYZE</literal> is
> also enabled. Otherwise, it defaults to <literal>FALSE</literal>.
Is that second sentence really needed? Because "BUFFERS ON" will never be
needed anymore (save as a no-op to allow the same explain queries to run
cross-version), and BUFFERS OFF outside of analyze is meaningless.
Cheers,
Greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2024-11-20 00:29:27 | Re: sunsetting md5 password support |
| Previous Message | Nikita Glukhov | 2024-11-20 00:06:16 | Re: SQL:2023 JSON simplified accessor support |