Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Christofides <michael(at)pgmustard(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
Date: 2024-11-20 06:26:37
Message-ID: CAECtzeUwpK5gNWQqoK4ZjwXANtdE2fWirJyaBDqkytPzfWZqzg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mer. 20 nov. 2024 à 01:13, Greg Sabino Mullane <htamfids(at)gmail(dot)com> a
écrit :

> I'm with Robert on this one. I'm a grudging +1 to buffers defaulting on,
> and a strong -1 to all the other proposals. Guillaume, the patch looks
> pretty good.
>

Thanks :)

> I would like to see some of the example output have more than just "shared
> hit" and "read" though: let's throw some "dirtied" and "written" in
> there as well.
>
>
OK, but I'm not sure which example I should pick to add dirtied and written
shared buffers. It looks kinda artificial. Should I choose one randomly?

It defaults to <literal>TRUE</literal> when <literal>ANALYZE</literal> is
>> also enabled. Otherwise, it defaults to <literal>FALSE</literal>.
>
>
> Is that second sentence really needed? Because "BUFFERS ON" will never be
> needed anymore (save as a no-op to allow the same explain queries to run
> cross-version), and BUFFERS OFF outside of analyze is meaningless.
>
>
Done in v3 with David's idea.

--
Guillaume.

Attachment Content-Type Size
v3-0001-Enable-BUFFERS-by-default-with-EXPLAIN-ANALYZE.patch text/x-patch 77.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-11-20 06:32:11 Re: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID
Previous Message Michael Paquier 2024-11-20 06:22:11 Re: PGSERVICEFILE as part of a normal connection string