Re: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID
Date: 2024-11-20 06:32:11
Message-ID: Zz2Ca2CEzH4GQpN8@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 15, 2024 at 11:33:37AM -0500, Peter Geoghegan wrote:
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency grounds.
>
> I propose this for the master branch only.

Perhaps this patch should also explain why this is better this way?
This path does not manipulate btpo_level, for one.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2024-11-20 07:25:53 Re: proposal: schema variables
Previous Message Guillaume Lelarge 2024-11-20 06:26:37 Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE