From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Disable emojis in Yarn output. |
Date: | 2018-05-30 20:50:09 |
Message-ID: | CAE+jjanH0F44dSkqjFppoUeRhheOcptiRVtUD0vy22cehGFvNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello Dave,
When running yarn linter after this commit we get the following:
yarn run v1.7.0
$ yarn eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .
$ /Users/pivotal/workspace/pgadmin4/web/node_modules/.bin/eslint
--emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .
Invalid option '--emoji' - perhaps you meant '--env'?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.
Thanks
Victoria && Joao
On Wed, May 30, 2018 at 4:42 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Disable emojis in Yarn output.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2d4c6ef9d7715c62310bd05dace97f7523a527d
>
> Modified Files
> --------------
> pkg/docker/Dockerfile | 4 ++--
> web/package.json | 20 ++++++++++----------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-05-30 20:52:42 | pgAdmin 4 commit: Revert failed Yarn changes. |
Previous Message | Joao De Almeida Pereira | 2018-05-30 20:47:11 | Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog |