| From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog |
| Date: | 2018-05-30 20:47:11 |
| Message-ID: | CAE+jja=MZXA6E=O_2D0-n9p=1nmeJneWQJL_+XUCr2Hs4V1BFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Murtuza,
We are having a hard time understanding the logic on the change.
If tunnel_authentication is not on the model and the tunnel_identify_file
is present, we change the tunnel_identify_file in the model to null? Is
this what you mean?
Thanks
Victoria && Joao
On Wed, May 30, 2018 at 9:27 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patch to fix the issue when you change any field in server
> dialog 'tunnel_identity_file' model value get included unnecessarily in the
> update request.
>
> eg: Change the server name and click on Save button, Check the request
> payload in network console.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-05-30 20:50:09 | Re: pgAdmin 4 commit: Disable emojis in Yarn output. |
| Previous Message | Dave Page | 2018-05-30 20:42:14 | pgAdmin 4 commit: Disable emojis in Yarn output. |