Re: pgAdmin 4 commit: Disable emojis in Yarn output.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Disable emojis in Yarn output.
Date: 2018-05-30 20:53:54
Message-ID: CA+OCxozr+i+dZUG524bmCNhOYYGor3xc4Eik82L0J_yb_wuFGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Yeah - I pushed by mistake (don't ask). It's reverted now.

Sorry!

On Wed, May 30, 2018 at 4:50 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hello Dave,
> When running yarn linter after this commit we get the following:
>
> yarn run v1.7.0
> $ yarn eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .
> $ /Users/pivotal/workspace/pgadmin4/web/node_modules/.bin/eslint --emoji false --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .
> Invalid option '--emoji' - perhaps you meant '--env'?
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
>
> Thanks
> Victoria && Joao
> ​
>
> On Wed, May 30, 2018 at 4:42 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Disable emojis in Yarn output.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
>> b2d4c6ef9d7715c62310bd05dace97f7523a527d
>>
>> Modified Files
>> --------------
>> pkg/docker/Dockerfile | 4 ++--
>> web/package.json | 20 ++++++++++----------
>> 2 files changed, 12 insertions(+), 12 deletions(-)
>>
>>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-05-30 21:06:32 Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1
Previous Message Dave Page 2018-05-30 20:53:08 pgAdmin 4 commit: Fix failed yarn changes