From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
---|---|
To: | Neethu Mariya Joy <neethumariyajoy(at)gmail(dot)com> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Bug #2309 fix |
Date: | 2018-03-01 22:05:57 |
Message-ID: | CAE+jjamYZfYvwqjonCsO_A5FNP-EuSzXNEdR8sk34hCNC3sUKA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello Neethu,
We run the patch though our test pipeline and all tests are green.
Everything looks good with this patch
Thanks
Joao
On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy(at)gmail(dot)com>
wrote:
> Hi,
> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
> at BITS Pilani.
>
> I've attempted to fix https://redmine.postgresql.org/issues/2309.
> Codemirrors catches all the keyboard and mouse events when 'readOnly'
> option is set to 'noCursor' and does not allow copying.
> So, I've set 'readOnly' option to true. In order to hide the cursor, I've
> added a class 'hide-cursor-workaround' and applied css styles to hide the
> cursor.
>
> I'm attaching my patch as bug2309.diff below as per the contribution
> guidelines.
>
> Hope this helps. Thank you for your consideration!
>
> Sincerely,
> Neethu Mariya Joy
> GitHub <https://github.com/Roboneet> | Linkedin
> <https://www.linkedin.com/in/neethu-mariya-joy-653655128/>
>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Joao De Almeida Pereira | 2018-03-01 22:10:54 | Re: Bug #3083 fix |
Previous Message | Neethu Mariya Joy | 2018-03-01 22:03:55 | Re: Feature #3061 |