From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
Cc: | Neethu Mariya Joy <neethumariyajoy(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug #2309 fix |
Date: | 2018-03-02 13:47:30 |
Message-ID: | CA+OCxowvMs6Yxy91D7q0a+84OPjBuBVUgm9RGpJyHn5f-7T-ng@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
Thank you both. I've committed this with a minor tweak to include a space
before the { in the CSS, to match the existing formatting.
Welcome to the project Neethu!
On Thu, Mar 1, 2018 at 10:05 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hello Neethu,
>
> We run the patch though our test pipeline and all tests are green.
> Everything looks good with this patch
>
> Thanks
> Joao
>
> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <
> neethumariyajoy(at)gmail(dot)com> wrote:
>
>> Hi,
>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
>> at BITS Pilani.
>>
>> I've attempted to fix https://redmine.postgresql.org/issues/2309.
>> Codemirrors catches all the keyboard and mouse events when 'readOnly'
>> option is set to 'noCursor' and does not allow copying.
>> So, I've set 'readOnly' option to true. In order to hide the cursor, I've
>> added a class 'hide-cursor-workaround' and applied css styles to hide the
>> cursor.
>>
>> I'm attaching my patch as bug2309.diff below as per the contribution
>> guidelines.
>>
>> Hope this helps. Thank you for your consideration!
>>
>> Sincerely,
>> Neethu Mariya Joy
>> GitHub <https://github.com/Roboneet> | Linkedin
>> <https://www.linkedin.com/in/neethu-mariya-joy-653655128/>
>>
>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-03-02 14:39:19 | pgAdmin 4 commit: Allow copying of SQL from the dashboard tables. Fixes |
Previous Message | Dave Page | 2018-03-02 13:46:12 | pgAdmin 4 commit: Allow text selection/copying from disabled CodeMirror |