Re: [patch] Move to Alembic migration system

From: Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Sarah McAlear <smcalear(at)pivotal(dot)io>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: [patch] Move to Alembic migration system
Date: 2017-03-23 16:00:35
Message-ID: CAE+jjamPqnfE0_5Q7MGu1h=QdAyVD7VjOS-=+ssaQxCYNeDbwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Hackers,

We found out a issue using Python 3 related to importing modules that we
corrected in the patch that is now attached.

Also we would like to know the status of this.

Thanks
Joao & Sarah

On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:

> Hi!
>
> We realized that this change was causing the tests to fail because the
> folder for the sqlite databases was not being created. We also updated the
> files to contain the missing headers.
>
> Thanks!
> Joao & Sarah
>
>
>
> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Ashesh, can you review/commit this please? One thing I notice on a
>> quick look through is that the file headers are missing everywhere.
>> They should be present in all source files, except where they would
>> bloat the data transfer from client to server.
>>
>> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>> wrote:
>> > Hi Hackers!
>> >
>> > It looks like our previous patch messed up some logging. Please use
>> this one
>> > instead.
>> >
>> > Thanks,
>> > Joao & Sarah
>> >
>> >
>> >
>> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>> wrote:
>> >>
>> >> Hi Hackers!
>> >>
>> >> Here's a patch to move to current db migration system to use Alembic.
>> >> Instructions to create new migrations are in the README.
>> >>
>> >> Thanks!
>> >> Joao & Sarah
>> >>
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

Attachment Content-Type Size
0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch application/octet-stream 44.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Atira Odhner 2017-03-23 17:58:27 Re: Javascript translations
Previous Message Joao Pedro De Almeida Pereira 2017-03-23 15:49:33 [patch] Raise InternalServerError while retrieving table DDL