Re: Javascript translations

From: Atira Odhner <aodhner(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Javascript translations
Date: 2017-03-23 17:58:27
Message-ID: CA+Vc24p-KU8K3PSAG0Libn7f6FjVYXCyGOYTpZtD_r2Y4vv6Mg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Dave.

1) String extraction no longer picks up strings in JS files. I guess
> we may need a custom extractor for babel?

Yeah, that's a good point. I didn't think about that. I'll put that in my
team's backlog coming up.

Here's a patch for the docs.

On Thu, Mar 23, 2017 at 8:37 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Tira,
>
> I've been spending spare minutes starting to move the JS translations
> to use your new mechanism with an aim to minimising the Jinja
> rendering. Unfortunately, I found a couple of issues; can you look
> into them please?
>
> 1) String extraction no longer picks up strings in JS files. I guess
> we may need a custom extractor for babel?
>
> 2) The docs were never updated to reflect the changes, e.g.
> https://www.pgadmin.org/docs4/dev/translations.html
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
0001-Update-the-docs-for-javascript-translations.patch application/octet-stream 1.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-03-24 06:46:34 Re: Re-vamping the history tab
Previous Message Joao Pedro De Almeida Pereira 2017-03-23 16:00:35 Re: [patch] Move to Alembic migration system