From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Atira Odhner <aodhner(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Javascript translations |
Date: | 2017-03-24 11:51:32 |
Message-ID: | CA+OCxoxYa03Tvk1106Z0cRePngXPK1AT13J3+61kSdR_VmRm_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied - though I changed it to "sources/translate" and "t"
as the function name as that's what's been used so far.
On Thu, Mar 23, 2017 at 5:58 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
> Thanks Dave.
>
>> 1) String extraction no longer picks up strings in JS files. I guess
>> we may need a custom extractor for babel?
>
>
> Yeah, that's a good point. I didn't think about that. I'll put that in my
> team's backlog coming up.
>
> Here's a patch for the docs.
>
>
> On Thu, Mar 23, 2017 at 8:37 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi Tira,
>>
>> I've been spending spare minutes starting to move the JS translations
>> to use your new mechanism with an aim to minimising the Jinja
>> rendering. Unfortunately, I found a couple of issues; can you look
>> into them please?
>>
>> 1) String extraction no longer picks up strings in JS files. I guess
>> we may need a custom extractor for babel?
>>
>> 2) The docs were never updated to reflect the changes, e.g.
>> https://www.pgadmin.org/docs4/dev/translations.html
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Devrim Gündüz | 2017-03-24 11:57:15 | Re: Last few steps for pgadmin4 on RHEL 6 |
Previous Message | Dave Page | 2017-03-24 11:41:17 | pgAdmin 4 commit: Fix path |