From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io> |
Subject: | Re: [patch] Move to Alembic migration system |
Date: | 2017-03-17 14:32:30 |
Message-ID: | CAGRPzo_P+4J2PC4cgYevfTiypF7OFYiELSdaAsCgrzP-y-1S-A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi!
We realized that this change was causing the tests to fail because the
folder for the sqlite databases was not being created. We also updated the
files to contain the missing headers.
Thanks!
Joao & Sarah
On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Ashesh, can you review/commit this please? One thing I notice on a
> quick look through is that the file headers are missing everywhere.
> They should be present in all source files, except where they would
> bloat the data transfer from client to server.
>
> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> wrote:
> > Hi Hackers!
> >
> > It looks like our previous patch messed up some logging. Please use this
> one
> > instead.
> >
> > Thanks,
> > Joao & Sarah
> >
> >
> >
> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> wrote:
> >>
> >> Hi Hackers!
> >>
> >> Here's a patch to move to current db migration system to use Alembic.
> >> Instructions to create new migrations are in the README.
> >>
> >> Thanks!
> >> Joao & Sarah
> >>
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
0001-Switch-to-Alembic-and-Flask-migration-db-migration-s.patch | application/octet-stream | 44.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Osahon Oduware | 2017-03-17 14:53:08 | QGIS Seem To Bypass PostgreSQL/PostGIS User Privileges/Permissions |
Previous Message | Dave Page | 2017-03-17 12:49:15 | Re: [pgAdmin4][Patch] To fix the issues in SQL editor module & Functions node |