| From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger |
| Date: | 2018-02-08 14:37:49 |
| Message-ID: | CAE+jjakNUTfk3JmTJAae0nqk_Aq6MUgKo5hq4vTcF1ZfNM3zHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hello Murtuza,
After some review of the code we do have some questions:
- Do we really need to have the shortcuts in the backend?(I already asked
this in Khushboo's patch)
- Do we need to have keyAction function(in direct.js) inside this
Javascript file or can we extract that an create some tests around it?
- Were there any tests created for these new shortcuts?
Thanks
Joao
On Thu, Feb 8, 2018 at 6:33 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to make shortcut configurable in debugger module.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-02-08 14:38:15 | Re: [pgadmin4] Hide tabs in create table |
| Previous Message | Joao De Almeida Pereira | 2018-02-08 14:27:51 | Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window. |