Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

Hi Joao,

On Thu, Feb 8, 2018 at 8:07 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hello Murtuza,
> After some review of the code we do have some questions:
> - Do we really need to have the shortcuts in the backend?(I already asked
> this in Khushboo's patch)
>
​Yes, to make them configurable by user, User can select the shortcut keys
as per their need and we will save them in sqlite database for future
reference and use it.

> - Do we need to have keyAction function(in direct.js) inside this
> Javascript file or can we extract that an create some tests around it?
>

​'​
keyAction
​' is a caller function and which executes the handler written in
'keyboard_shortcuts.js​'

> - Were there any tests created for these new shortcuts?
>
​They are not actual shortcuts but we have used accesskeys for each buttons
in debugger toolbar, earlier they were hard coded accesskeys now they are
configurable by user through preference dialog.
For Inner panel navigation shortcut keys testcase, I'm not sure how to
simulate wcDocker Panels in JS tests without actual DOM element, so I've
not added any tests for that.

>
> Thanks
> Joao
>
> On Thu, Feb 8, 2018 at 6:33 AM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to make shortcut configurable in debugger module.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>