Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

From: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.
Date: 2018-02-08 14:27:51
Message-ID: CAE+jjakN9=mW82LVp98DVQYyCugpPKKJnFqvRr5i9a8=1ADS8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Khushboo,
We were looking into the your patch and have some questions.

- What is the reason being the front end shortcuts being registered in
the python code? There is already some precedent in the code, but this
looks like a concern of the front end.
- Didn't saw any tests around this, did you create them?

While testing it out, in the Mac, when I press Option + Shift + E while
selecting 'Tables' node, no information is given to the user that the
object as no properties, like Option + Shift + V does, is this
intentional?(Same with Option + Shift + D)

In which situation can Direct debugging be used?
Should the documentation specify the Shortcuts for Mac as well?

Thanks
Joao

On Thu, Feb 8, 2018 at 2:08 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch for RM #2899: Provide access
> keys/shortcuts to all commonly used menu options in the main window.
>
> Shortcuts provided in this patch:
>
> Alt+Shift+Q Open the query tool
> Alt+Shift+V View data
> Alt+Shift+C Open the context menu
> Alt+Shift+N Create an object
> Alt+Shift+E Edit the object properties
> Alt+Shift+D Delete the object
> Alt+Shift+G Direct debugging
>
>
> Thanks,
> Khushboo
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-02-08 14:37:49 Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger
Previous Message Murtuza Zabuawala 2018-02-08 11:32:46 [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger