Re: pgsql: Remove pg_class.relhaspkey

On Thu, Mar 15, 2018 at 7:43 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On 2018-03-14 19:35:40 +0000, Peter Eisentraut wrote:
> > Remove pg_class.relhaspkey
> >
> > It is not used for anything internally, and it cannot be relied on for
> > external uses, so it can just be removed. To correct recommended way to
> > check for a primary key is in pg_index.
> >
> > Discussion: https://www.postgresql.org/message-id/flat/b1a24c6c-6913-
> f89c-674e-0704f0ed69db(at)2ndquadrant(dot)com
>
> I'm not clear on the mechanics, and the animal doesn't show the critical
> log. But this might have caused the issue, being the only commit between
> runs:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=
> crake&dt=2018-03-14%2019%3A37%3A20
>
> Andrew, any chance you could modify the module to capture
> pg_upgrade_dump_*.log?
>

I will look at it. Meanwhile I have fixed a typo in the module. The
database in question is supposed to have been dropped as it has caused
other issues in the past, but due to the typo it wasn't.

Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe
that's not a brilliant thing to do in a test (or maybe the test should drop
the MV after it's done).

cheers

andrew