| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net>, andrew(at)dunslane(dot)net |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Remove pg_class.relhaspkey |
| Date: | 2018-03-14 21:13:44 |
| Message-ID: | 20180314211344.3x2bhr7bmqmtvor6@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2018-03-14 19:35:40 +0000, Peter Eisentraut wrote:
> Remove pg_class.relhaspkey
>
> It is not used for anything internally, and it cannot be relied on for
> external uses, so it can just be removed. To correct recommended way to
> check for a primary key is in pg_index.
>
> Discussion: https://www.postgresql.org/message-id/flat/b1a24c6c-6913-f89c-674e-0704f0ed69db(at)2ndquadrant(dot)com
I'm not clear on the mechanics, and the animal doesn't show the critical
log. But this might have caused the issue, being the only commit between
runs:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2018-03-14%2019%3A37%3A20
Andrew, any chance you could modify the module to capture
pg_upgrade_dump_*.log?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-03-14 22:09:07 | Re: pgsql: Remove pg_class.relhaspkey |
| Previous Message | Peter Eisentraut | 2018-03-14 20:44:26 | Re: pgsql: Support INOUT arguments in procedures |