Re: pgsql: Remove pg_class.relhaspkey

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove pg_class.relhaspkey
Date: 2018-03-14 22:36:43
Message-ID: 1452.1521067003@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe
> that's not a brilliant thing to do in a test (or maybe the test should drop
> the MV after it's done).

OH. Is that what it's doing? The cause of the failure is immediately
obvious then. pg_class now lacks a relhaspkey column, but the matview
is still dependent on one being there.

I concur that this is not well-considered test design.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-03-14 23:11:32 Re: pgsql: Remove pg_class.relhaspkey
Previous Message Tom Lane 2018-03-14 22:32:23 Re: pgsql: Remove pg_class.relhaspkey