| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Remove pg_class.relhaspkey |
| Date: | 2018-03-14 23:11:32 |
| Message-ID: | 20180314231132.4ac5hlxhs7m2xbhg@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe
> > that's not a brilliant thing to do in a test (or maybe the test should drop
> > the MV after it's done).
>
> OH. Is that what it's doing? The cause of the failure is immediately
> obvious then. pg_class now lacks a relhaspkey column, but the matview
> is still dependent on one being there.
>
> I concur that this is not well-considered test design.
It seems very strange to me that the test_ddl_deparse database would be
used by a pg_upgrade test, but OK. I'll change it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2018-03-14 23:34:44 | Re: pgsql: Support INOUT arguments in procedures |
| Previous Message | Tom Lane | 2018-03-14 22:36:43 | Re: pgsql: Remove pg_class.relhaspkey |