From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Revive num_dead_tuples column of pg_stat_progress_vacuum |
Date: | 2024-06-07 01:22:50 |
Message-ID: | CAD21AoBvKT5r+R2KSAmLqA6-qde8yFx6w5a08G=AiEYFrw1Uew@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 5, 2024 at 7:19 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>
>
> > On 4 Jun 2024, at 00:26, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Thank you! Vacuum enhancement is a really good step forward, and this small change would help a lot of observability tools.
>
>
> > On 4 Jun 2024, at 00:49, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> >
> > Can we rename this to num_dead_item_ids (or something similar) in
> > passing?
>
> I do not insist, but many tools will have to adapt to this change [0,1]. However, most of tools will have to deal with removed max_dead_tuples anyway [2], so this is not that big problem.
True, this incompatibility would not be a big problem.
num_dead_item_ids seems good to me. I've updated the patch that
incorporated the comment from Álvaro[1].
Regards,
[1] https://www.postgresql.org/message-id/202406041535.pmyty3ci4pfd%40alvherre.pgsql
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Reintroduce-dead-tuple-counter-in-pg_stat_progres.patch | application/x-patch | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-06-07 02:04:15 | Re: question regarding policy for patches to out-of-support branches |
Previous Message | Jeff Davis | 2024-06-06 23:48:12 | Re: report on not thread-safe functions |