From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Revive num_dead_tuples column of pg_stat_progress_vacuum |
Date: | 2024-06-11 13:38:06 |
Message-ID: | CAD21AoD8osU3gZp7-V1RVJ_KjeQfRhKfqJDUE+24mfv5RzJ3Rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 7, 2024 at 10:22 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Jun 5, 2024 at 7:19 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> >
> >
> >
> > > On 4 Jun 2024, at 00:26, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Thank you! Vacuum enhancement is a really good step forward, and this small change would help a lot of observability tools.
> >
> >
> > > On 4 Jun 2024, at 00:49, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > >
> > > Can we rename this to num_dead_item_ids (or something similar) in
> > > passing?
> >
> > I do not insist, but many tools will have to adapt to this change [0,1]. However, most of tools will have to deal with removed max_dead_tuples anyway [2], so this is not that big problem.
>
> True, this incompatibility would not be a big problem.
>
> num_dead_item_ids seems good to me. I've updated the patch that
> incorporated the comment from Álvaro[1].
I'm going to push the v2 patch in a few days if there is no further comment.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2024-06-11 13:42:44 | Re: confirmed flush lsn seems to be move backward in certain error cases |
Previous Message | Joseph Koshakow | 2024-06-11 13:31:39 | Re: Remove dependence on integer wrapping |