| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Revive num_dead_tuples column of pg_stat_progress_vacuum |
| Date: | 2024-06-05 10:19:41 |
| Message-ID: | AE42BBD3-D2C6-40E9-81D7-B052205E24C7@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 4 Jun 2024, at 00:26, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
Thank you! Vacuum enhancement is a really good step forward, and this small change would help a lot of observability tools.
> On 4 Jun 2024, at 00:49, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> Can we rename this to num_dead_item_ids (or something similar) in
> passing?
I do not insist, but many tools will have to adapt to this change [0,1]. However, most of tools will have to deal with removed max_dead_tuples anyway [2], so this is not that big problem.
Best regards, Andrey Borodin.
[0] https://github.com/jalexandre0/pgmetrics/blob/61cb150f6d1e535513a6a07fc0c6d751fbed517e/collector/collect.go#L1289
[1] https://github.com/DataDog/integrations-core/blob/250553f3b91d25de28add93afeb929e2abf67e53/postgres/datadog_checks/postgres/util.py#L517
[2] https://github.com/search?q=num_dead_tuples+language%3AGo&type=code
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-06-05 10:57:13 | Re: apply_scanjoin_target_to_paths and partitionwise join |
| Previous Message | Bharath Rupireddy | 2024-06-05 09:47:24 | Re: Logical Replication of sequences |