| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix a typo in xlogreader.c |
| Date: | 2021-01-12 10:43:24 |
| Message-ID: | CAD21AoAzz6qipFJBbGEaHmyWxvvNDp8httbwLR9tUQWaTjUs2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The function comment of RestoreBlockImage() seems not correct since it
returns a boolean, not the buffer number.
/*
* Restore a full-page image from a backup block attached to an XLOG record.
*
* Returns the buffer number containing the page.
*/
bool
RestoreBlockImage(XLogReaderState *record, uint8 block_id, char *page)
Attached the patch that fixes it.
Regards,
--
Masahiko Sawada
EnterpriseDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| fix_typo_xlogreader.patch | application/octet-stream | 588 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-01-12 11:08:30 | Re: list of extended statistics on psql |
| Previous Message | Thomas Munro | 2021-01-12 10:30:13 | Re: O(n^2) system calls in RemoveOldXlogFiles() |