| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a typo in xlogreader.c |
| Date: | 2021-01-12 15:07:21 |
| Message-ID: | 20210112150721.GA8344@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jan-12, Masahiko Sawada wrote:
> Hi,
>
> The function comment of RestoreBlockImage() seems not correct since it
> returns a boolean, not the buffer number.
You're right -- this has always been wrong. Pushed your patch.
Thank you!
--
Álvaro Herrera 39°49'30"S 73°17'W
"It takes less than 2 seconds to get to 78% complete; that's a good sign.
A few seconds later it's at 90%, but it seems to have stuck there. Did
somebody make percentages logarithmic while I wasn't looking?"
http://smylers.hates-software.com/2005/09/08/1995c749.html
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-01-12 15:10:24 | Re: O(n^2) system calls in RemoveOldXlogFiles() |
| Previous Message | Tom Lane | 2021-01-12 14:55:23 | Re: Executing inet_server_addr/port() in parallel workers |