Re: attndims, typndims still not enforced, but make the value within a sane threshold

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date: 2024-09-20 02:11:00
Message-ID: CACJufxEF9_o_tZeNg+rDV5MfQW6eYTdM9MUcy0Z5-VMWvf-tOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 18, 2024 at 10:35 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> > The last time this was discussed, I think the conclusion was
> > we should remove attndims and typndims entirely on the grounds
> > that they're useless. I certainly don't see a point in adding
> > more logic that could give the misleading impression that they
> > mean something.
> >

attached patch removes attndims and typndims entirely.
some tests skipped in my local my machine, not skipped are all OK.

Attachment Content-Type Size
v1-0001-remove-pg_attribute-attndims-and-pg_type-typndims.patch text/x-patch 61.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2024-09-20 02:27:42 Re: Add on_error and log_verbosity options to file_fdw
Previous Message Thomas Munro 2024-09-20 01:57:57 Re: Robocopy might be not robust enough for never-ending testing on Windows