Re: attndims, typndims still not enforced, but make the value within a sane threshold

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
Date: 2024-09-20 13:27:47
Message-ID: Zu14U-whwiOu86bc@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 20, 2024 at 10:11:00AM +0800, jian he wrote:
> On Wed, Sep 18, 2024 at 10:35 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > > The last time this was discussed, I think the conclusion was
> > > we should remove attndims and typndims entirely on the grounds
> > > that they're useless. I certainly don't see a point in adding
> > > more logic that could give the misleading impression that they
> > > mean something.
> > >
>
>
> attached patch removes attndims and typndims entirely.
> some tests skipped in my local my machine, not skipped are all OK.

I have been hoping for a patch links this because I feel the existence
of these system columns is deceptive since we don't honor them properly.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-09-20 13:45:25 Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Previous Message Marcos Pegoraro 2024-09-20 12:36:51 Why mention to Oracle ?