From: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points |
Date: | 2024-09-04 16:05:32 |
Message-ID: | CACG=eza1Z_FG-ZgNRieK6gHoxghBymezqcHJkdOWdxALbLWSVA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 4 Sept 2024 at 03:40, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Any thoughts about the attached? This makes installcheck work here
> with and without the configure switch.
>
>
Works for me with configure build. Meson build, obviously, still need extra
"meson compile install-test-files" step
as expected. From your patch, I see that you used safe_psql call to check
for availability of the injection_points
extension. Are there some hidden, non-obvious reasons for it? It's much
simpler to check output of the
pg_config as Álvaro suggested above, does it? And we don't need active node
for this. Or I miss something?
And one other thing I must mention. I don't know why, but my pg_config from
meson build show empty configure
despite the fact, I make pass the same options in both cases.
autotools:
$ ./pg_config --configure
'--enable-debug' '--enable-tap-tests' '--enable-depend' ....
meson:
$ ./pg_config --configure
--
Best regards,
Maxim Orlov.
From | Date | Subject | |
---|---|---|---|
Next Message | Ranier Vilela | 2024-09-04 16:50:24 | Avoid dead code (contrib/pg_visibility/pg_visibility.c) |
Previous Message | Alexander Lakhin | 2024-09-04 16:00:00 | Re: GUC names in messages |