| From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][runtime][patch]: Runtime not working in all platform |
| Date: | 2016-08-08 13:11:44 |
| Message-ID: | CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Please find attached patch file to fix the below issue.
*Issue:-*
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.
Prevent the user attempting to run external commands if the bin path is not
configured. Fixes #1177
f78024808e80fef67de1aef5c97d1756c6771c0e
It is working in browser but Qt's web engine is not able to handle the
error and goes into infinite loop of paint event which may crash the
pgAdmin4 application.
Can you please review and commit this patch ?
Thanks,
Neel Patel
| Attachment | Content-Type | Size |
|---|---|---|
| runtime_issue.patch | application/octet-stream | 668 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2016-08-08 13:34:17 | Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type |
| Previous Message | Surinder Kumar | 2016-08-08 12:23:42 | Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type |