Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
Date: 2016-08-08 13:42:27
Message-ID: CA+OCxowyUB546W14gxZ20wLb9cG1LS7XL_eAMWSF2oM+nCSBHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Aug 8, 2016 at 2:11 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file to fix the below issue.
>
> Issue:-
> Runtime was not working in all platform due to syntax error in javascript.
> This issue was introduced due to below commit.
>
> Prevent the user attempting to run external commands if the bin path is not
> configured. Fixes #1177
>
> f78024808e80fef67de1aef5c97d1756c6771c0e
>
>
> It is working in browser but Qt's web engine is not able to handle the error
> and goes into infinite loop of paint event which may crash the pgAdmin4
> application.
>
> Can you please review and commit this patch ?
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Navnath Gadakh 2016-08-08 14:07:32 Re: pgAdmin IV : Unittest modular patch
Previous Message Dave Page 2016-08-08 13:42:15 pgAdmin 4 commit: Fix a JS error in the runtime caused by f78024808e80f