| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Document that server will start even if it's unable to open some TCP/IP ports |
| Date: | 2023-09-13 00:25:44 |
| Message-ID: | CABwTF4WmrP0BUpUbAq5O90ybFL-7Hh82KfYP8ZUXAViUVBjjSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> > >> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> > >> something along the lines of
> > >>
> > >> If listen_addresses is not empty, the server will start only if it can
> > >> listen on at least one of the specified addresses. A warning will be
> > >> emitted for any addresses that the server cannot listen on.
> > >
> > > Good idea, updated patch attached.
> >
> > I still think we should say "listen on an address" instead of "open a
> > port," but otherwise it LGTM.
>
> Agreed, I never liked the "port" mention. I couldn't figure how to get
> "open" out of the warning sentence though. Updated patch attached.
LGTM.
Best regards,
Gurjeet
http://Gurje.et
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-09-13 00:27:35 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | David E. Wheeler | 2023-09-13 00:16:53 | JSON Path and GIN Questions |