From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Document that server will start even if it's unable to open some TCP/IP ports |
Date: | 2023-09-26 23:02:37 |
Message-ID: | ZRNjDQCCtL14+oHh@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Sep 12, 2023 at 05:25:44PM -0700, Gurjeet Singh wrote:
> On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >
> > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> > > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> > > >> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> > > >> something along the lines of
> > > >>
> > > >> If listen_addresses is not empty, the server will start only if it can
> > > >> listen on at least one of the specified addresses. A warning will be
> > > >> emitted for any addresses that the server cannot listen on.
> > > >
> > > > Good idea, updated patch attached.
> > >
> > > I still think we should say "listen on an address" instead of "open a
> > > port," but otherwise it LGTM.
> >
> > Agreed, I never liked the "port" mention. I couldn't figure how to get
> > "open" out of the warning sentence though. Updated patch attached.
>
> LGTM.
Patch applied back to PG 11.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2023-09-26 23:13:32 | Re: Is this a problem in GenericXLogFinish()? |
Previous Message | Bruce Momjian | 2023-09-26 22:54:25 | Re: pg_upgrade instructions involving "rsync --size-only" might lead to standby corruption? |