| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Document that server will start even if it's unable to open some TCP/IP ports |
| Date: | 2023-09-08 14:52:10 |
| Message-ID: | ZPs1Gg5DtPYLPA2G@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> >> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> >> something along the lines of
> >>
> >> If listen_addresses is not empty, the server will start only if it can
> >> listen on at least one of the specified addresses. A warning will be
> >> emitted for any addresses that the server cannot listen on.
> >
> > Good idea, updated patch attached.
>
> I still think we should say "listen on an address" instead of "open a
> port," but otherwise it LGTM.
Agreed, I never liked the "port" mention. I couldn't figure how to get
"open" out of the warning sentence though. Updated patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| Attachment | Content-Type | Size |
|---|---|---|
| listen.diff | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-09-08 14:55:47 | Re: Possibility to disable `ALTER SYSTEM` |
| Previous Message | Jean-Christophe Arnu | 2023-09-08 14:41:42 | FDW pushdown of non-collated functions |