Re: clean.pl on Windows fails to remove flex output

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: clean.pl on Windows fails to remove flex output
Date: 2011-07-02 15:54:22
Message-ID: CABUevExDR_nsa=Dzu4BMH94LDicGJj8y5yxu-_2Y1duHSkPzPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 2, 2011 at 17:51, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> wrote:
> Hi folks
>
> I've noticed while testing the VC 2010 patches that clean.pl in
> src/tools/msvc doesn't remove files generated by flex. I landed up with a
> broken configuration while testing my x64 builds that caused the creation of
> zero-size outputs for bootscanner.c etc. These weren't re-generated on
> re-build even after a clean, and because they're in .gitignore they aren't
> flagged as dirty in the tree either. Because an empty file is a valid C
> compilation unit, everything proceeded merrily until linkage failed.
>
> Should clean.pl be removing such files? Or, since they're probably included
> in release source tarballs, would a separate "gitclean.pl" be required?

clean.pl? I don't even have that file, I only have clean.bat...

And if you're talking about that one, have you tried "clean dist"
which is what should correspond to make distclean, and remove those
files?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-07-02 16:03:23 Re: clean.pl on Windows fails to remove flex output
Previous Message Craig Ringer 2011-07-02 15:51:13 clean.pl on Windows fails to remove flex output