clean.pl on Windows fails to remove flex output

From: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>
To: pgsql-hackers(at)postgresql(dot)org
Subject: clean.pl on Windows fails to remove flex output
Date: 2011-07-02 15:51:13
Message-ID: 4E0F3E71.2080006@postnewspapers.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi folks

I've noticed while testing the VC 2010 patches that clean.pl in
src/tools/msvc doesn't remove files generated by flex. I landed up with
a broken configuration while testing my x64 builds that caused the
creation of zero-size outputs for bootscanner.c etc. These weren't
re-generated on re-build even after a clean, and because they're in
.gitignore they aren't flagged as dirty in the tree either. Because an
empty file is a valid C compilation unit, everything proceeded merrily
until linkage failed.

Should clean.pl be removing such files? Or, since they're probably
included in release source tarballs, would a separate "gitclean.pl" be
required?

--
Craig Ringer

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-07-02 15:54:22 Re: clean.pl on Windows fails to remove flex output
Previous Message Andres Freund 2011-07-02 14:19:07 Re: Deriving release notes from git commit messages