Re: clean.pl on Windows fails to remove flex output

From: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: clean.pl on Windows fails to remove flex output
Date: 2011-07-03 01:42:52
Message-ID: 4E0FC91C.3030407@postnewspapers.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/07/2011 11:54 PM, Magnus Hagander wrote:
> On Sat, Jul 2, 2011 at 17:51, Craig Ringer<craig(at)postnewspapers(dot)com(dot)au> wrote:
>> Hi folks
>>
>> I've noticed while testing the VC 2010 patches that clean.pl in
>> src/tools/msvc doesn't remove files generated by flex. I landed up with a
>> broken configuration while testing my x64 builds that caused the creation of
>> zero-size outputs for bootscanner.c etc. These weren't re-generated on
>> re-build even after a clean, and because they're in .gitignore they aren't
>> flagged as dirty in the tree either. Because an empty file is a valid C
>> compilation unit, everything proceeded merrily until linkage failed.
>>
>> Should clean.pl be removing such files? Or, since they're probably included
>> in release source tarballs, would a separate "gitclean.pl" be required?
>
> clean.pl? I don't even have that file, I only have clean.bat...
>
> And if you're talking about that one, have you tried "clean dist"
> which is what should correspond to make distclean, and remove those
> files?

Gah. Reading the file before posting would've been a good idea - sorry.

--
Craig Ringer

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2011-07-03 02:08:28 Re: libpq SSL with non-blocking sockets
Previous Message Robert Haas 2011-07-03 01:04:55 Re: [v9.2] Fix leaky-view problem, part 1