Re: [v9.2] Fix leaky-view problem, part 1

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Noah Misch <noah(at)2ndquadrant(dot)com>, Kohei Kaigai <Kohei(dot)Kaigai(at)emea(dot)nec(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [v9.2] Fix leaky-view problem, part 1
Date: 2011-07-03 01:04:55
Message-ID: CA+TgmoYvE4+sAc1OSoZUqc9RJH632k+Q+b0i=kRFW21FkmYuEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 2, 2011 at 3:46 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sat, Jul 2, 2011 at 1:54 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>>> BTW, regarding to the statement support for security barrier views,
>>> the following syntax might be more consistent with existing ones:
>>>  CREATE VIEW view_name WITH ( param [=value]) AS query ... ;
>>> rather than
>>>  CREATE SECURITY VIEW view_name AS query ...;
>>>
>>> Any comments?
>
>> I think I mildly prefer CREATE SECURITY VIEW to the parameter syntax
>> in this case, but I don't hate the other one.
>
> The WITH idea seems a bit more future-proof; in particular it would
> easily accommodate specifying a security type, if we decide we need
> various levels of leak-proof-ness.

Or other kinds of view options. I'm not going to argue against that
too forcefully, since I've advocated introducing that sort of syntax
elsewhere. I think it's mostly that I thought this feature might be
significant enough to merit a syntax that would make it a little more
prominent, but perhaps not.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2011-07-03 01:42:52 Re: clean.pl on Windows fails to remove flex output
Previous Message Josh Kupershmidt 2011-07-03 00:48:44 Re: patch: Allow \dd to show constraint comments