Re: Bug report: OIDs, roles and Windows (signedness issue?)

From: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Bug report: OIDs, roles and Windows (signedness issue?)
Date: 2014-01-10 08:06:49
Message-ID: CAB8KJ=gjLLUo3GC6ecxtWmvAWURjB1idLKiwU2qj_cKpdzx_TA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
> 2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
>
>>>
>>> BTW other objects (tables, schemas etc.) with OIDs greater than 256^4/2 - 1
>>> don't seem to be affected by this.
>>
>> It's been a while since I've looked at the pgAdmin source, but some wild
>> grepping shows that in:
>>
>> pgadmin/schema/pgRole.cpp
>>
>> the role OID is set with:
>>
>> role->iSetOid(roles->GetLong(wxT("oid")));
>>
>> whereas almost everywhere else it's set with GetOid(), e.g.
>>
>> table->iSetOid(tables->GetOid(wxT("oid")));
>>
>> which may or may not have something to do with the issue.
>
> If that is the problem, then here's a patch. Untested as I don't have a Windows
> build environment available, though I might be able to cobble one together
> next week.

Just wondering - has anyone been able to look into this? Unfortunately I still
don't have a Windows build environment available to test.

Regards

Ian Barwick

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2014-01-10 08:38:54 Re: Bug report: OIDs, roles and Windows (signedness issue?)
Previous Message Dave Page 2014-01-09 10:48:36 Re: [PATCH] Added a menu option to disable code folding