Re: Bug report: OIDs, roles and Windows (signedness issue?)

2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:

>>
>> BTW other objects (tables, schemas etc.) with OIDs greater than 256^4/2 - 1
>> don't seem to be affected by this.
>
> It's been a while since I've looked at the pgAdmin source, but some wild
> grepping shows that in:
>
> pgadmin/schema/pgRole.cpp
>
> the role OID is set with:
>
> role->iSetOid(roles->GetLong(wxT("oid")));
>
> whereas almost everywhere else it's set with GetOid(), e.g.
>
> table->iSetOid(tables->GetOid(wxT("oid")));
>
> which may or may not have something to do with the issue.

If that is the problem, then here's a patch. Untested as I don't have a Windows
build environment available, though I might be able to cobble one together
next week.

Regards

Ian Barwick