From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug report: OIDs, roles and Windows (signedness issue?) |
Date: | 2014-01-10 08:38:54 |
Message-ID: | CAG7mmowHY=EvFkJpELWW9Sqa5LToV4ZZGPAw3W27mpFxBxCDDg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Sorry - it was missed due to busy schedule.
I will take a look at it.
Thanks for the reminder.
On Fri, Jan 10, 2014 at 1:36 PM, Ian Lawrence Barwick <barwick(at)gmail(dot)com>wrote:
> 2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
> > 2013/11/22 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
> >
> >>>
> >>> BTW other objects (tables, schemas etc.) with OIDs greater than
> 256^4/2 - 1
> >>> don't seem to be affected by this.
> >>
> >> It's been a while since I've looked at the pgAdmin source, but some wild
> >> grepping shows that in:
> >>
> >> pgadmin/schema/pgRole.cpp
> >>
> >> the role OID is set with:
> >>
> >> role->iSetOid(roles->GetLong(wxT("oid")));
> >>
> >> whereas almost everywhere else it's set with GetOid(), e.g.
> >>
> >> table->iSetOid(tables->GetOid(wxT("oid")));
> >>
> >> which may or may not have something to do with the issue.
> >
> > If that is the problem, then here's a patch. Untested as I don't have a
> Windows
> > build environment available, though I might be able to cobble one
> together
> > next week.
>
> Just wondering - has anyone been able to look into this? Unfortunately I
> still
> don't have a Windows build environment available to test.
>
>
> Regards
>
> Ian Barwick
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
From | Date | Subject | |
---|---|---|---|
Next Message | Ian Lawrence Barwick | 2014-01-10 08:41:34 | Re: Bug report: OIDs, roles and Windows (signedness issue?) |
Previous Message | Ian Lawrence Barwick | 2014-01-10 08:06:49 | Re: Bug report: OIDs, roles and Windows (signedness issue?) |