Re: Restore support for USE_ASSERT_CHECKING in extensions only

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Andrew Kane <andrew(at)ankane(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Restore support for USE_ASSERT_CHECKING in extensions only
Date: 2025-01-11 00:05:07
Message-ID: CAApHDvrfWSqxWakzEUdmSVdzrHCP1=AKKBxo7sco2nRF9mqkwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 11 Jan 2025 at 12:56, Andrew Kane <andrew(at)ankane(dot)org> wrote:
> I've updated the patch to make verify_compact_attribute a no-op.
>
> The extension sets USE_ASSERT_CHECKING, which is why the macro approach doesn't work (it won't take that path).
>
> Also, it looks like it fails when creating the extension / loading the shared library (on Ubuntu), not when linking (as I misstated earlier).

I think the v2 patch looks fine then. I'll push.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-11 00:15:09 Re: Restore support for USE_ASSERT_CHECKING in extensions only
Previous Message David Rowley 2025-01-10 23:56:29 Re: Restore support for USE_ASSERT_CHECKING in extensions only